Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURE: Some OpenBSD tweaks + let the endianness check build if there's no __attribute__ #3925

Merged
merged 3 commits into from Jun 12, 2022

Conversation

dwatteau
Copy link
Contributor

@dwatteau dwatteau commented May 30, 2022

The commits are unrelated but they're small changes to the same file.

OpenBSD

Contrary to FreeBSD, OpenBSD completely removed its /dev/sequencer support back in 2013, since sndio is its replacement (for which we already have a MIDI backend):
https://marc.info/?l=openbsd-cvs&m=136333866832000&w=2

So the first commit moves OpenBSD to its own section and always disables SEQ MIDI there, as was recently done for macOS in commit 1aabe90.

The other OpenBSD commit just disables -pedantic there, because some system headers make the build noisy, otherwise. (It builds fine with -std=c++11, though.)

(Basically, this is a backport of what the official OpenBSD port has been doing for some years; I'm trying to reduce the number of patches which are applied in the ports tree.)

__attribute__

The other commit is related to the endianness test in configure: it has some __attribute((used)) lines coming from Fedora since they use LTO by default (well, the check itself could maybe be rewritten so that it will never trigger any dead-code elimination, and remove EBCDIC support ;) but __attribute__ is used unconditionally so it could fail compiling with some non-GCC-compatible compilers. In practice, configure implicitly targets GCC-compatible compilers I believe, but…

OpenBSD removed its /dev/sequencer support in 2013, and uses the sndio
API instead.
configure Outdated Show resolved Hide resolved
dwatteau added 2 commits May 30, 2022
…_ support

__attribute__((used)) here comes from Fedora which uses LTO by default
but this is a GCC-ism, so let this code compile if the compiler is not
GCC-compatible.
OpenBSD is fine with std_variant=c++ with C++11, but -pedantic is still
noisy for some system header files.
@dwatteau dwatteau force-pushed the fix/configure-openbsd-no-seq-midi branch from a168ced to 7780a1b Compare May 30, 2022
@sev-
Copy link
Member

@sev- sev- commented Jun 12, 2022

Thank you!

@sev- sev- merged commit a7922fc into scummvm:master Jun 12, 2022
8 checks passed
@dwatteau dwatteau deleted the fix/configure-openbsd-no-seq-midi branch Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants