GRAPHICS: Remove false positive warning from Win cursor group parser #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hard to prove this is correct because the Microsoft docs for the cursor group format is garbled and has CURSORDIR listed as many of the field types when they're actually WORD or DWORD for some reason:
https://docs.microsoft.com/en-us/windows/win32/menurc/resdir
... but right now this code is spamming a bunch of false-positive warnings when loading cursors from Obsidian because the "planes" field is usually 32 or 64. I think what's going on is that the Planes/BitCount fields are actually xHotSpot/yHotSpot for cursors, corresponding with the difference between ICO and CUR format.
Either way, in-the-wild data is coming up with other numbers that appear to be valid, so this removes the check.