Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: Remove false positive warning from Win cursor group parser #3938

Merged
merged 1 commit into from Jun 12, 2022

Conversation

elasota
Copy link
Contributor

@elasota elasota commented Jun 2, 2022

Hard to prove this is correct because the Microsoft docs for the cursor group format is garbled and has CURSORDIR listed as many of the field types when they're actually WORD or DWORD for some reason:
https://docs.microsoft.com/en-us/windows/win32/menurc/resdir

... but right now this code is spamming a bunch of false-positive warnings when loading cursors from Obsidian because the "planes" field is usually 32 or 64. I think what's going on is that the Planes/BitCount fields are actually xHotSpot/yHotSpot for cursors, corresponding with the difference between ICO and CUR format.

Either way, in-the-wild data is coming up with other numbers that appear to be valid, so this removes the check.

@sev-
Copy link
Member

@sev- sev- commented Jun 12, 2022

OK, thanks

@sev- sev- merged commit 27f5d32 into scummvm:master Jun 12, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants