Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYPNO: Reduce memory usage when opening .lib archives #3940

Merged
merged 2 commits into from Jun 19, 2022

Conversation

ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Jun 2, 2022

No description provided.

@ccawley2011 ccawley2011 requested a review from neuromancer Jun 2, 2022
@neuromancer
Copy link
Contributor

@neuromancer neuromancer commented Jun 4, 2022

This looks good, but it will be merged after master is unfrozen just in case. Btw, do you know much memory is saved using MemoryReadStream?

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Jun 4, 2022

This looks good, but it will be merged after master is unfrozen just in case. Btw, do you know much memory is saved using MemoryReadStream?

I'm not sure about exact figures, but loading all archive entries into memory up front causes the DS port to run out of memory when the engine starts, while only loading entries on demand allows Wetlands to start correctly.

@neuromancer
Copy link
Contributor

@neuromancer neuromancer commented Jun 4, 2022

Neat!, how is the general experience of playing Wetlands in the DS using your PRs? Is it playable?

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Jun 4, 2022

Neat!, how is the general experience of playing Wetlands in the DS using your PRs? Is it playable?

It's playable, but can be slow in places. PR #3963 helps, though, and I'm currently investigating some optimizations in the Smacker decoder which may also improve things.

@neuromancer
Copy link
Contributor

@neuromancer neuromancer commented Jun 13, 2022

Please solve the conflict, so I can merge it. Thanks a lot! 🙂

@bluegr
Copy link
Member

@bluegr bluegr commented Jun 19, 2022

Thanks for your work!
Fixed the conflict - squashing into master, since @neuromancer approved this

@bluegr bluegr merged commit caba912 into scummvm:master Jun 19, 2022
8 checks passed
@neuromancer
Copy link
Contributor

@neuromancer neuromancer commented Jun 19, 2022

Awesome work, thanks @ccawley2011 and @bluegr

@ccawley2011 ccawley2011 deleted the hypno-libfile branch Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants