Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURE: Deduplicate simple compiler flag support tests #3945

Merged
merged 1 commit into from Jun 18, 2022

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jun 2, 2022

No description provided.

@orgads
Copy link
Contributor Author

@orgads orgads commented Jun 2, 2022

I see that @aquadran fixed the packed-member warning in GLK recently. So should we leave it enabled?

configure Outdated Show resolved Hide resolved
Copy link
Member

@lephilousophe lephilousophe left a comment

I made some comments inline.

configure Show resolved Hide resolved
configure Show resolved Hide resolved
devtools/create_project/xcode.cpp Outdated Show resolved Hide resolved
@orgads orgads force-pushed the build-flags branch 2 times, most recently from a6655fb to 2ff4152 Compare Jun 2, 2022
@orgads orgads changed the title BUILD: Update warning suppression flags CONFIGURE: Deduplicate simple compiler flag support tests Jun 2, 2022
@orgads orgads force-pushed the build-flags branch 2 times, most recently from 43b92fe to 792e055 Compare Jun 2, 2022
configure Outdated Show resolved Hide resolved
@bluegr
Copy link
Member

@bluegr bluegr commented Jun 18, 2022

Nice work! @orgads, please address the issue above in order to merge this

@bluegr
Copy link
Member

@bluegr bluegr commented Jun 18, 2022

Thanks for your work! Merging

@bluegr bluegr merged commit 9e5ef28 into scummvm:master Jun 18, 2022
8 checks passed
@orgads orgads deleted the build-flags branch Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants