Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLK: Fix bad indentation #3948

Merged
merged 1 commit into from Jun 3, 2022
Merged

GLK: Fix bad indentation #3948

merged 1 commit into from Jun 3, 2022

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jun 2, 2022

Reported by GCC 12:

../scummvm/engines/glk/zcode/processor.cpp: In member function 'void Glk::ZCode::Processor::call(Glk::ZCode::zword, int, Glk::ZCode::zword*, int)':
../scummvm/engines/glk/zcode/processor.cpp:349:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  349 |                 if (h_version <= V4)            // V1 to V4 games provide default
      |                 ^~
../scummvm/engines/glk/zcode/processor.cpp:352:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  352 |                         *--_sp = (zword)((argc-- > 0) ? args[i] : value);
      |                         ^

Reported by GCC 12:
../scummvm/engines/glk/zcode/processor.cpp: In member function 'void Glk::ZCode::Processor::call(Glk::ZCode::zword, int, Glk::ZCode::zword*, int)':
../scummvm/engines/glk/zcode/processor.cpp:349:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  349 |                 if (h_version <= V4)            // V1 to V4 games provide default
      |                 ^~
../scummvm/engines/glk/zcode/processor.cpp:352:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  352 |                         *--_sp = (zword)((argc-- > 0) ? args[i] : value);
      |                         ^
@dreammaster dreammaster merged commit 5c0af77 into scummvm:master Jun 3, 2022
8 checks passed
@orgads orgads deleted the glk-indentation branch Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants