Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Move 80-bit float parsing from Director to Common #3953

Merged
merged 3 commits into from Jun 3, 2022

Conversation

elasota
Copy link
Contributor

@elasota elasota commented Jun 3, 2022

Per request, moves extended precision float parsing from Director to Common and adds proper handling of subnormal numbers.

Put in a little bit of futureproofing because Intel x87 can actually load the same format but has slightly different flags for INF/NaN, for now it only supports MC68881/SANE semantics.

"Should there be code to code to byte-swap an entire 80-bit value?" Uh maybe, since 8087 values are stored that way, but so far the only 2 known cases of 80-bit floats in data are always big endian.

@sev-
Copy link
Member

@sev- sev- commented Jun 3, 2022

Thank you. I'll squash the commits so they stay compilable

@sev- sev- merged commit a90a1a0 into scummvm:master Jun 3, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants