COMMON: Move 80-bit float parsing from Director to Common #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I'll squash the commits so they stay compilable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Per request, moves extended precision float parsing from Director to Common and adds proper handling of subnormal numbers.
Put in a little bit of futureproofing because Intel x87 can actually load the same format but has slightly different flags for INF/NaN, for now it only supports MC68881/SANE semantics.
"Should there be code to code to byte-swap an entire 80-bit value?" Uh maybe, since 8087 values are stored that way, but so far the only 2 known cases of 80-bit floats in data are always big endian.