Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYPNO: Optimize rendering routines #3963

Merged
merged 2 commits into from Jun 6, 2022
Merged

Conversation

ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Jun 4, 2022

Graphics::Surface::scale() is slow, and can be avoided if the original surface is already the requested dimensions. In addition, using more specialised routines for copying and colour key blitting instead of the more generic blitFrom and transBlitFrom from Graphics::ManagedSurface also provides a performance boost on slower systems.

This includes the changes from PR #3956.

@ccawley2011 ccawley2011 requested a review from neuromancer Jun 4, 2022
@neuromancer
Copy link
Contributor

@neuromancer neuromancer commented Jun 4, 2022

Uhm, where exactly scale was used?

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Jun 4, 2022

Uhm, where exactly scale was used?

It's used in HypnoEngine::updateScreen() for videos with scaling enabled, which seems to cover all of the ones intended to run in full screen.

@neuromancer
Copy link
Contributor

@neuromancer neuromancer commented Jun 5, 2022

@ccawley2011 can you please resolve this conflict? 🙂

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Jun 5, 2022

@ccawley2011 can you please resolve this conflict? 🙂

OK, done.

@neuromancer neuromancer merged commit 79a752c into scummvm:master Jun 6, 2022
8 checks passed
@ccawley2011 ccawley2011 deleted the hypno-surface branch Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants