Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID: Improve touch input #3967

Merged
merged 2 commits into from Jun 13, 2022
Merged

Conversation

lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Jun 5, 2022

This PR do two things:

  • it adds settings to let user decide which touch mode is preferred in menus, in 2D games, in 3D games.
  • it merges toggle screen keyboard button with the touch mode button: a long press on the button shows the keyboard while a normal press toggles the touch mode. When keyboard is shown, any press will hide it.

There are 3 settings: in menus, in 2D games, in 3D games
A long press on the button shows the keyboard
@lephilousophe lephilousophe requested a review from antoniou79 Jun 5, 2022
@antoniou79
Copy link
Contributor

@antoniou79 antoniou79 commented Jun 13, 2022

I just tested for a bit. This looks good to me.

My quick notes:

  1. We should also update documentation since the displaying of keyboard on demand is now changed (to the long press of the touch mode button)
  2. The menu overlay key does not seem necessary for the ScummVM launcher. It can probably be removed in that context -- not for this PR, but something to keep in mind (unless there are objections)

Merging.

I am in favor of backporting it to 2.6 branch, but I'll let you decide.

@antoniou79 antoniou79 merged commit bbcdda6 into scummvm:master Jun 13, 2022
8 checks passed
@lephilousophe
Copy link
Member Author

@lephilousophe lephilousophe commented Jun 15, 2022

About 1) I will do it ASAP.
About 2) I didn't want to fiddle with this because I didn't know the history about it.

I will backport as soon as the documentation is written.

@lephilousophe lephilousophe deleted the android-input branch Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants