Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASE: Reorganize code to save command line settings #3969

merged 1 commit into from Jun 12, 2022


Copy link

@criezy criezy commented Jun 5, 2022

Proposing this change as a pull request as I am not completely sure if this is a good idea or not.

The main impact of this change is that settings stored in the Session domain are no longer saved in the Transient domain, which saves a bit of memory in ConfMan. It also keeps the logic to transform '-' to '_' in a single place.

I was also thinking that instead of listing the settings that go into the Session domain, it might be better to list the settings that go into the Transient domain. That way we can easily see which ones have not been migrated yet, and see if it would make sense to changes those. But I was too lazy to build such a list.

sev- approved these changes Jun 12, 2022
Copy link

@sev- sev- left a comment

I like the idea

@criezy criezy merged commit dfaa00c into scummvm:master Jun 12, 2022
8 checks passed
@criezy criezy deleted the cmdline-session branch Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants