Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOON: Add vielogom.smk to German demo detection #3970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

einstein95
Copy link
Contributor

@einstein95 einstein95 commented Jun 5, 2022

If you install the demo, this file isn't copied. Additionally ScummVM will segfault.

If you install the demo, this file isn't copied. Additionally ScummVM will segfault.
@einstein95 einstein95 marked this pull request as ready for review Jun 5, 2022
@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented Jun 5, 2022

If the user tries to add an installed version of the demo with this PR, ScummVM will give this message

The game in 'TOONDEMO' seems to be an unknown game variant.

Please report the following data to the ScummVM team at
https://bugs.scummvm.org/ along with the name of the game you tried to add and
its version, language, etc.:

Matched game IDs for the toon engine: toon-demo

  {"generic.svl", 0, "5eb99850ada22f0b8cf6392262d4dd07", 9404599},
  {"local.pak", 0, "bf5da4c03f78ffbd643f12122319366e", 3250841},

Backtrace for the mentioned segfault

#0  0x0000555555761f59 in Toon::AnimationInstance::setFrame(int) (this=0x0, position=0) at ../engines/toon/anim.cpp:552
#1  0x000055555576d65a in Toon::CharacterDrew::playStandingAnim() (this=0x5555566ac570) at ../engines/toon/drew.cpp:83
#2  0x000055555577633a in Toon::ScriptFunc::sys_Cmd_Set_Actor_Facing(Toon::EMCState*) (this=0x555556539a00, state=0x7fffffffba90) at ../engines/toon/script_func.cpp:357
#3  0x000055555577aafb in Common::Functor1Mem<Toon::EMCState*, int, Toon::ScriptFunc>::operator()(Toon::EMCState*) const (this=0x555556539c30, v1=0x7fffffffba90)
    at ../common/func.h:460
#4  0x000055555577b5a7 in Toon::EMCInterpreter::op_sysCall(Toon::EMCState*) (this=0x55555653c2c0, script=0x7fffffffba90) at ../engines/toon/script.cpp:321
#5  0x000055555577c5a4 in Toon::EMCInterpreter::run(Toon::EMCState*) (this=0x55555653c2c0, script=0x7fffffffba90) at ../engines/toon/script.cpp:222
#6  0x0000555555746a7e in Toon::ToonEngine::initChapter() (this=0x5555565509f0) at ../engines/toon/toon.cpp:1753
#7  0x000055555574632b in Toon::ToonEngine::init() (this=0x5555565509f0) at ../engines/toon/toon.cpp:135
#8  0x000055555574e9b3 in Toon::ToonEngine::run() (this=0x5555565509f0) at ../engines/toon/toon.cpp:1170
#9  0x000055555572718c in runGame(Plugin const*, Plugin const*, OSystem&, Common::String const&) (plugin=0x555555cd3ca0, enginePlugin=0x555555cd1fd0, system=..., debugLevels=...)
    at ../base/main.cpp:318
#10 0x0000555555725378 in scummvm_main(int, char const* const*) (argc=2, argv=0x7fffffffdcc8) at ../base/main.cpp:619
#11 0x0000555555722831 in main(int, char**) (argc=2, argv=0x7fffffffdcc8) at ../backends/platform/sdl/posix/posix-main.cpp:44

@bluegr
Copy link
Member

@bluegr bluegr commented Jun 7, 2022

I see two different issues here. One is with the detection entry itself, which is addressed here.
The other is with the crash of ScummVM. We shouldn't crash due to a missing video, and instead we should continue with a warning that the video file is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants