Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Correctly reposition mouse on loading savegames when using render mode with its own scaling #3972

Merged

Conversation

eriktorbjorn
Copy link
Member

@eriktorbjorn eriktorbjorn commented Jun 6, 2022

Since the saved mouse position uses game coordinates, any rendering mode that causes the graphics to be rescaled will have to convert them to screen coordinates before warping the mouse there. (The rendering mode scalers are separate from the backend scalers.)

Note that I have only tested this with Mac Indy3 and Loom, and a little bit with the Hercules rendering mode. It would be good if someone else could help me test, particularly the "(_useCJKMode && _textSurfaceMultiplier == 2)" thing.

Since the saved mouse position uses game coordinates, any rendering mode
that causes the graphics to be rescaled will have to convert them to
screen coordinates before warping the mouse there. (The rendering mode
scalers are separate from the backend scalers.)
@eriktorbjorn eriktorbjorn merged commit 6226efc into scummvm:master Jun 6, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant