Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix caret position in list widget #3975

Merged
merged 1 commit into from Jun 7, 2022

Conversation

eriktorbjorn
Copy link
Member

@eriktorbjorn eriktorbjorn commented Jun 7, 2022

Strip formatting from the list widget string before taking the length of it to calculate the caret position. This can be seen e.g. in the save dialog when not using the icon view.

Otherwise, you'll end up with something like this:

image

(It was a bit tricky to get a screenshot, because the keypress to save screenshots in ScummVM will apparently cause the caret to be hidden.)

@eriktorbjorn eriktorbjorn force-pushed the list-widget-caret-position branch from 2246e71 to bf0b792 Compare Jun 7, 2022
@eriktorbjorn eriktorbjorn changed the title GUI: Fix caret position in list view GUI: Fix caret position in list widget Jun 7, 2022
Strip formatting from the list widget string before taking the length of
it to calculate the caret position. This can be seen e.g. in the save
dialog when not using the icon view.
@eriktorbjorn eriktorbjorn force-pushed the list-widget-caret-position branch from bf0b792 to 9269182 Compare Jun 7, 2022
@sev-
Copy link
Member

@sev- sev- commented Jun 7, 2022

Yep, another overlook from me. Thanks!

@sev- sev- merged commit 8b94209 into scummvm:master Jun 7, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants