Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: Fix segmentation fault for thumbnail from incomplete fill #3980

Merged
merged 1 commit into from Jun 12, 2022

Conversation

antoniou79
Copy link
Contributor

@antoniou79 antoniou79 commented Jun 11, 2022

Common::fill() fills up to but not including the address of the last item

Previously the last item of array v was not filled with 0, so if the rest of the code in the scaleLine() method did not update it, it would have a random int value which could cause segmentation fault when using the scale() method.

I had this issue while doing some test recording with the event recorder.

Common::fill fills up to but not including the address of the last item

Previously the last item of array v was not filled with 0, so if the rest of the code in the scaleLine() method did not update it, it would have a random init value which could cause segmentation fault when using the scale() method.
@sev- sev- merged commit 9e96c12 into scummvm:master Jun 12, 2022
8 checks passed
@sev-
Copy link
Member

@sev- sev- commented Jun 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants