GUI: Introduce a maximum dialog width/height for the options dialogs #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR scummvm#3976 changed the game and global options dialogs so that they are inside the ScummVM main window, instead of the game list chooser. We now limit the option dialog width and size, so that there isn't too much spacing in large resolutions.
|
So, after talking about this on Discord, it was agreed that this is an improvement for large resolutions. Merging (squashing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR #3976 changed the game and global options dialogs so that they are
inside the ScummVM main window, instead of the game list chooser.
We now limit the option dialog width and size, so that there isn't too
much spacing in large resolutions.
This is based on the current theme functionality, as suggested by @sev-
Small resolutions (same as the current dialog):
Large resolutions:
