Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Introduce a maximum dialog width/height for the options dialogs #3982

Merged
merged 2 commits into from Jun 12, 2022

Conversation

bluegr
Copy link
Member

@bluegr bluegr commented Jun 11, 2022

PR #3976 changed the game and global options dialogs so that they are
inside the ScummVM main window, instead of the game list chooser.

We now limit the option dialog width and size, so that there isn't too
much spacing in large resolutions.

This is based on the current theme functionality, as suggested by @sev-

Small resolutions (same as the current dialog):
image

Large resolutions:
image

PR scummvm#3976 changed the game and global options dialogs so that they are
inside the ScummVM main window, instead of the game list chooser.

We now limit the option dialog width and size, so that there isn't too
much spacing in large resolutions.
@bluegr
Copy link
Member Author

@bluegr bluegr commented Jun 12, 2022

So, after talking about this on Discord, it was agreed that this is an improvement for large resolutions.
Thus, now the options dialogs will have a maximum size, and won't fill the entire screen with spacing in large resolutions.

Merging (squashing)

@bluegr bluegr merged commit 68ee726 into scummvm:master Jun 12, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant