Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Fix Kerner's text mentioning the wrong person in New York #3983

Conversation

dwatteau
Copy link
Contributor

@dwatteau dwatteau commented Jun 12, 2022

This comes from quickly diffing my Indy4 Talkie PC release with my Talkie Macintosh release, but TCRF also mentions this among some other differences. The Macintosh releases often fixed some small issues in the original games… I think this one's worth "backporting".

Context

In one of the first scenes, Kerner will use the phone booth in New York to report that he stole some interesting stuff. The talkie version changed these lines for some reason, but in the PC talkie release the new text doesn't match the new audio:

  • Kerner says: "Dr. Ubermann… Fantastic news! We've found the treasure we seek."
  • but the text prints: "Fritz… Fantastic news! I think we've found the treasure we seek."

the real problem is the wrong name, here. Here's a YouTube example: https://www.youtube.com/watch?v=LZZXJ3zCRDQ&t=1217s

The 1994 Macintosh release I have here fixed this line, fortunately (note that there are several Macintosh releases with different content). So this PR just replace the "Fritz" line with the "Dr. Ubermann" line if we find it in an English talkie version.

There was an official Japanese version with the English voices, but I don't have it and it shouldn't be as problematic there. AFAIK, every other translated talkie version is a fan-translation, which may or may not have fixed this on its own.

How to test

  1. Pick up any English talkie version of Indy4
  2. Start the game with the 1112 boot param and wait for Kerner to use the phone booth outside
  3. Kerner should start his conversation by saying "Dr Uberman…" and the audio and text should match

On the floppy releases, nothing should change. I don't know about the English FM-TOWNS version, but there are many checks so it shouldn't do anything bad.

The Talkie version of Indy4 changed Kerner's line when he uses the phone
booth in New York (reusing some words from the research lab scene), but
the text doesn't match with the voice in most releases: he says Ubermann
but the text mentions Fritz, in the English version.

The 1994 Talkie Macintosh release fixed this line, so we can replicate
this later, official fix as an enhancement for all the English talkie
releases.
@dwatteau
Copy link
Contributor Author

@dwatteau dwatteau commented Jun 12, 2022

Also of interest, the Macintosh version:

  1. works around the Hey you! audio glitch (#1208) by reusing the What are you doing? line from the guy eating a sandwich in the submarine… eh.
  2. changes Kerner's voice for Indy's when picking up the "Achtung Kerner" telegram at the dig site (as happens with Trottier later)
  3. removes the "We're XXX miles of Thera" line from the captain of the small boat, since there's no audio for the numbers.

but I would call them "different approaches" instead of "real improvements" (we handle 1. differently, 2. is a matter of taste and 3. removes some precious information) so I don't think this should be backported to the other talkie versions.

@bluegr
Copy link
Member

@bluegr bluegr commented Jun 19, 2022

Quite a straightforward fix for this inconsistency. Thanks for your work! Merging

@bluegr bluegr merged commit 06edf3d into scummvm:master Jun 19, 2022
8 checks passed
@dwatteau dwatteau deleted the fix/scumm-indy4-backport-fixed-talkie-kerner-line-from-macintosh-release branch Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants