SCUMM: Fix Kerner's text mentioning the wrong person in New York #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Talkie version of Indy4 changed Kerner's line when he uses the phone booth in New York (reusing some words from the research lab scene), but the text doesn't match with the voice in most releases: he says Ubermann but the text mentions Fritz, in the English version. The 1994 Talkie Macintosh release fixed this line, so we can replicate this later, official fix as an enhancement for all the English talkie releases.
|
Also of interest, the Macintosh version:
but I would call them "different approaches" instead of "real improvements" (we handle 1. differently, 2. is a matter of taste and 3. removes some precious information) so I don't think this should be backported to the other talkie versions. |
|
Quite a straightforward fix for this inconsistency. Thanks for your work! Merging |
dwatteau
deleted the
fix/scumm-indy4-backport-fixed-talkie-kerner-line-from-macintosh-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This comes from quickly diffing my Indy4 Talkie PC release with my Talkie Macintosh release, but TCRF also mentions this among some other differences. The Macintosh releases often fixed some small issues in the original games… I think this one's worth "backporting".
Context
In one of the first scenes, Kerner will use the phone booth in New York to report that he stole some interesting stuff. The talkie version changed these lines for some reason, but in the PC talkie release the new text doesn't match the new audio:
"Dr. Ubermann… Fantastic news! We've found the treasure we seek.""Fritz… Fantastic news! I think we've found the treasure we seek."the real problem is the wrong name, here. Here's a YouTube example: https://www.youtube.com/watch?v=LZZXJ3zCRDQ&t=1217s
The 1994 Macintosh release I have here fixed this line, fortunately (note that there are several Macintosh releases with different content). So this PR just replace the "Fritz" line with the "Dr. Ubermann" line if we find it in an English talkie version.
There was an official Japanese version with the English voices, but I don't have it and it shouldn't be as problematic there. AFAIK, every other translated talkie version is a fan-translation, which may or may not have fixed this on its own.
How to test
1112boot param and wait for Kerner to use the phone booth outsideOn the floppy releases, nothing should change. I don't know about the English FM-TOWNS version, but there are many checks so it shouldn't do anything bad.