Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Add detection entries for multiple demos and games #3987

Merged
merged 8 commits into from Jun 22, 2022

Conversation

einstein95
Copy link
Contributor

@einstein95 einstein95 commented Jun 13, 2022

No description provided.

sev-
sev- approved these changes Jun 13, 2022
Copy link
Member

@sev- sev- left a comment

Great work. Only one question regarding fileio.

engines/director/resource.cpp Outdated Show resolved Hide resolved
engines/director/lingo/xlibs/miscx.cpp Show resolved Hide resolved
@bluegr
Copy link
Member

@bluegr bluegr commented Jun 13, 2022

Nice work!
This should be split into multiple commits. There is a single big commit that includes not only detection, but functional related changes and additions.

Please, split the changes into more fine grained commits

Copy link
Member

@bluegr bluegr left a comment

Please split the changes in multiple commits

einstein95 added 7 commits Jun 22, 2022
including:
demos from Software Buyer's Guide (v7n1)
demo from Your Computer - Hardware and Software Buyers Guide (Australian Windows Publishing) (1997)
Neon Genesis Evangelion: EVA-00 Paper Figure
Spelunx GameTap/Steam remaster
@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented Jun 22, 2022

@bluegr @sev- I've split the commits up, please double check I haven't broken anything

@sev-
Copy link
Member

@sev- sev- commented Jun 22, 2022

Thanks!

@sev- sev- merged commit d60f949 into scummvm:master Jun 22, 2022
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants