Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Refactor dumping of RIFX chunks to dump all archive chunks #3991

Merged
merged 1 commit into from Jun 14, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 14, 2022

This change implements Archive::dumpChunks() to dump all the Archive chunks instead of just RIFX ones.

@djsrv
Copy link
Member

@djsrv djsrv commented Jun 14, 2022

Nice. This function looks like it dumps a single chunk though, so shouldn't it be called dumpChunk()?

@@ -276,6 +305,7 @@ void MacArchive::readTags() {
res.offset = res.size = 0; // unused
res.name = _resFork->getResName(tagArray[i], idArray[j]);
debug(3, "Found MacArchive resource '%s' %d: %s", tag2str(tagArray[i]), idArray[j], res.name.c_str());
dumpChunk(res, out);
Copy link
Member

@sev- sev- Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be wrapped in if (ConfMan.getBool("dump_scripts"))

@sev-
Copy link
Member

@sev- sev- commented Jun 14, 2022

Thanks!

@sev- sev- merged commit ecd6f21 into scummvm:master Jun 14, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants