DIRECTOR: LINGO: Implement kTheModified field in CastMember::getField() #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
reviewed
Jun 14, 2022
| @@ -661,7 +661,7 @@ Datum CastMember::getField(int field) { | |||
| d = 1; // Not loaded handled in Lingo::getTheCast | |||
| break; | |||
| case kTheModified: | |||
| warning("STUB: CastMember::getField():: Unprocessed getting field \"%s\" of cast %d", g_lingo->field2str(field), _castId); | |||
| d = (int) _modified; | |||
There was a problem hiding this comment.
Please do not insert space between type cast and var, e.g. d = (int)_modified;
|
Please explain how it was tested. |
1 similar comment
|
Please explain how it was tested. |
|
This got conflicts. You need to rebase. |
sev-
reviewed
Jun 22, 2022
| @@ -73,7 +73,7 @@ class CastMember : public Object<CastMember> { | |||
| virtual bool isEditable() { return false; } | |||
| virtual void setEditable(bool editable) {} | |||
| virtual bool isModified() { return _modified; } | |||
| virtual void setModified(bool modified) { _modified = modified; } | |||
| void setModified(bool modified); | |||
There was a problem hiding this comment.
Why did you drop the virtual modifier here?
There was a problem hiding this comment.
You are right. It wasn't necessary. But it wasn't getting inherited and overridden so I saw no harm in doing that
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a quick fix to implement the STUB for the
Modifiedproperty of CastMember