Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement kTheModified field in CastMember::getField() #3992

Merged
merged 1 commit into from Jun 23, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 14, 2022

This is a quick fix to implement the STUB for the Modified property of CastMember

@@ -661,7 +661,7 @@ Datum CastMember::getField(int field) {
d = 1; // Not loaded handled in Lingo::getTheCast
break;
case kTheModified:
warning("STUB: CastMember::getField():: Unprocessed getting field \"%s\" of cast %d", g_lingo->field2str(field), _castId);
d = (int) _modified;
Copy link
Member

@sev- sev- Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not insert space between type cast and var, e.g. d = (int)_modified;

@sev-
Copy link
Member

@sev- sev- commented Jun 14, 2022

Please explain how it was tested.

1 similar comment
@sev-
Copy link
Member

@sev- sev- commented Jun 14, 2022

Please explain how it was tested.

@r41k0u r41k0u marked this pull request as draft Jun 15, 2022
@sev-
Copy link
Member

@sev- sev- commented Jun 20, 2022

This got conflicts. You need to rebase.

@r41k0u r41k0u marked this pull request as ready for review Jun 22, 2022
@@ -73,7 +73,7 @@ class CastMember : public Object<CastMember> {
virtual bool isEditable() { return false; }
virtual void setEditable(bool editable) {}
virtual bool isModified() { return _modified; }
virtual void setModified(bool modified) { _modified = modified; }
void setModified(bool modified);
Copy link
Member

@sev- sev- Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you drop the virtual modifier here?

Copy link
Contributor Author

@r41k0u r41k0u Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. It wasn't necessary. But it wasn't getting inherited and overridden so I saw no harm in doing that

@sev-
Copy link
Member

@sev- sev- commented Jun 23, 2022

Thanks

@sev- sev- merged commit 761c99c into scummvm:master Jun 23, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants