Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement setting of ForeColor and BackColor propert… #3993

Merged
merged 1 commit into from Jun 14, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 14, 2022

This change implements the setting of BackColor and ForeColor for ShapeCastMember and TextCastMember in Castmember::setField(). These changes have been tested using the backColor of cast and foreColor of cast workshop movies

@r41k0u r41k0u force-pushed the setColors branch 2 times, most recently from 59673ac to b360813 Compare Jun 14, 2022
@@ -700,8 +700,8 @@ bool CastMember::setField(int field, const Datum &d) {

switch (field) {
case kTheBackColor:
warning("STUB: CastMember::setField(): Unprocessed setting field \"%s\" of cast %d", g_lingo->field2str(field), _castId);
return false;
_cast->getCastMember(_castId)->setBackColor(d.asInt());
Copy link
Member

@sev- sev- Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it tested? I thought that _modified flag should be also raised.

@sev-
Copy link
Member

@sev- sev- commented Jun 14, 2022

Thanks!

@sev- sev- merged commit a2a3760 into scummvm:master Jun 14, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants