Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement setting of kTheRect field in CastMember::setField() #3994

Merged
merged 1 commit into from Jun 16, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 14, 2022

This change prevents setting of _initialRect of the CastMember from the setField() function and implements the STUB

warning("CastMember::setField(): Wrong Datum Type %d for setting Rect", d.type);
return false;
}
_cast->getCastMember(_castId)->_initialRect = Common::Rect(d.u.farr->arr[0].asInt(), d.u.farr->arr[1].asInt(), d.u.farr->arr[2].asInt(), d.u.farr->arr[3].asInt());
Copy link
Member

@sev- sev- Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was it tested? Also, did you check if it works with ARRAY of len > 3?

@sev-
Copy link
Member

@sev- sev- commented Jun 14, 2022

Please explain how it was tested.

@r41k0u
Copy link
Contributor Author

@r41k0u r41k0u commented Jun 15, 2022

My Bad. This is a read-only field of CastMember

@sev-
Copy link
Member

@sev- sev- commented Jun 16, 2022

Thanks!

@sev- sev- merged commit a2a73f3 into scummvm:master Jun 16, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants