DIRECTOR: LINGO: Implement copyToClipBoard and pasteClipBoardInto STU… #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
reviewed
Jun 15, 2022
|
|
||
| g_lingo->dropStack(nargs); | ||
| Frame *currentFrame = g_director->getCurrentMovie()->getScore()->_frames[g_director->getCurrentMovie()->getScore()->getCurrentFrame()]; |
There was a problem hiding this comment.
Please simplify this code by writing something like:
Movie *movie = g_director->getCurrentMovie();
Score *score = movie->getScore();and then using these variables further down the code.
…Bs in Lingo Builtins
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implements the clipboard as a pointer to CastMemberID (as usage in Lingo would mean copying from existing CastMembers). This CastMemberID can then be used to load the CastMember and paste it at the given location. These changes have been tested using the
copyToClipBoard castworkshop movie