Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement copyToClipBoard and pasteClipBoardInto STU… #3998

Merged
merged 1 commit into from Jun 16, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 14, 2022

Implements the clipboard as a pointer to CastMemberID (as usage in Lingo would mean copying from existing CastMembers). This CastMemberID can then be used to load the CastMember and paste it at the given location. These changes have been tested using the copyToClipBoard cast workshop movie


g_lingo->dropStack(nargs);
Frame *currentFrame = g_director->getCurrentMovie()->getScore()->_frames[g_director->getCurrentMovie()->getScore()->getCurrentFrame()];
Copy link
Member

@sev- sev- Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify this code by writing something like:

Movie *movie = g_director->getCurrentMovie();
Score *score = movie->getScore();

and then using these variables further down the code.

@sev-
Copy link
Member

@sev- sev- commented Jun 16, 2022

Thanks!

@sev- sev- merged commit ec3a741 into scummvm:master Jun 16, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants