Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement clearGlobals Lingo command #4002

Merged
merged 1 commit into from Jun 15, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 15, 2022

This change implements the stubbed function LB::b_clearGlobals(). Functionality is implemented as described in the Lingo Dictionary for D4 and has been tested using the clearGlobals workshop movie. Behaviour in ScummVM matches movie's behaviour in BasiliskII

g_lingo->printSTUBWithArglist("b_clearGlobals", nargs);

g_lingo->dropStack(nargs);
for (auto it = g_lingo->_globalvars.begin(); it != g_lingo->_globalvars.end(); it++) {
Copy link
Member

@sev- sev- Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you can just call g_lingo->_globalvars.clear() and that's it.

@sev-
Copy link
Member

@sev- sev- commented Jun 15, 2022

Thanks

@sev- sev- merged commit 21ac3dd into scummvm:master Jun 15, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants