Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement Number of Castmembers STUB in Lingo::getTheEntity() #4009

Merged
merged 1 commit into from Jun 20, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 16, 2022

This change implements the getting of number of castMembers. THe changes have been tested using the number of castMembers workshop movie which shows identical behaviour to as observed in BasiliskII

@sev-
Copy link
Member

@sev- sev- commented Jun 16, 2022

I wonder, how does the original work when a Shared Cast is present. Could you please check? Simple dropping of a random D4 Shared Cast to the directory with number of castMembers and see if the number changes and we report it properly.

@r41k0u
Copy link
Contributor Author

@r41k0u r41k0u commented Jun 20, 2022

Yes. It also shows the number of CastMembers loaded in the sharedCast and adds them

@sev-
Copy link
Member

@sev- sev- commented Jun 20, 2022

Thanks!

@sev- sev- merged commit 826abc5 into scummvm:master Jun 20, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants