DIRECTOR: LINGO: Implement the beepOn property and remove their respective STUBs #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
requested changes
Jun 16, 2022
engines/director/lingo/lingo-the.cpp
Outdated
| @@ -377,7 +377,8 @@ Datum Lingo::getTheEntity(int entity, Datum &id, int field) { | |||
| d = g_lingo->_actorList; | |||
| break; | |||
| case kTheBeepOn: | |||
| getTheEntitySTUB(kTheBeepOn); | |||
| d.type = INT; | |||
| d.u.i = (int) g_director->getCurrentMovie()->_isBeepOn; | |||
There was a problem hiding this comment.
Please, do not add space after type cast.
engines/director/lingo/lingo-the.cpp
Outdated
| @@ -936,7 +937,7 @@ void Lingo::setTheEntity(int entity, Datum &id, int field, Datum &d) { | |||
| g_lingo->_actorList = d; | |||
| break; | |||
| case kTheBeepOn: | |||
| setTheEntitySTUB(kTheBeepOn); | |||
| g_director->getCurrentMovie()->_isBeepOn = (bool) d.u.i; | |||
There was a problem hiding this comment.
Same thing regarding extra space after the type cast.
| @@ -87,6 +87,8 @@ Movie::Movie(Window *window) { | |||
| _timeOutKeyDown = true; | |||
| _timeOutMouse = true; | |||
| _timeOutPlay = false; | |||
|
|
|||
| _isBeepOn = false; | |||
There was a problem hiding this comment.
I thought that beep is on by default, not off. Could you please check with the original?
There was a problem hiding this comment.
According to the D4 Dictionary, beepOn is FALSE by default. I will check with basiliskII and update
There was a problem hiding this comment.
I tested the movie. beepOn is off by default in the original too
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implements the beepOn property by creating a bool
_isBeepOnfor the movie and emitting a beep at every mouse down event which meets these conditions:Tested using
beepOnworkshop movie and shows identical behaviour as in BasiliskII