SCUMM: Fix missing voice when selling back the hub cap and pirate hat #4011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This one was found by Threepwang while he was testing his own French translation.
Context
This only happens with the Ultimate Talkie edition of Monkey Island 2, when you go to the Booty Boutique and try to buy/sell some objects.
Script 215 in room 48 (talkie edition 0.2) does this:
but for the hub cap and the pirate hat, the comparison is wrong, it should check for
550
and549
since they must be in your inventory to be sold again.So, the first two
if ()
would never match and you'd fall back to the voice-lessCan I sell back this XXX...
. Not game-breaking, but the audio sample is there, and the Ultimate Talkie edition was all about fixing and improving everything in the orignal game :)As usual, I try to take many precautions in my checks (so if a future version of the Ultimate Edition appears, this shouldn't cause any problem). In this particular case, I don't check for
_enableEnhancements
since this fan-made edition is about enhancements in the first place (a similar reasoning is already applied to an existing workaround in this same file).How to test
-b 619
boot param.With this fix, you should hear Guybrush's voice again when he asks about selling back these objects.