Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement kTheFixStageSize property STUB #4021

Merged
merged 1 commit into from Jun 20, 2022

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 20, 2022

This change implements fixStageSize STUB by adding a bool and Rect variable for it in the Director namespace. The changes have been tested using fixStageSize-movie 1 workshop movie and it shows identical behaviour as seen in BasiliskII

} else {
//Let the compiler unroll this loop
for (int i = 0; i < 4; i++)
stream->readSint16();
Copy link
Member

@sev- sev- Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to explicitly write here (void)stream->readSint16();

I'll do it after merge

@sev-
Copy link
Member

@sev- sev- commented Jun 20, 2022

Thank you.

@sev- sev- merged commit ee24217 into scummvm:master Jun 20, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants