Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement searchCurrentFolder STUB in Lingo::getTheEntity() #4027

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented Jun 20, 2022

This change returns true for the property searchCurrentFolder as we won't be supporting the setting of this property to False

@r41k0u r41k0u changed the title Search DIRECTOR: LINGO: Implement searchCurrentFolder STUB in Lingo::getTheEntity() Jun 20, 2022
@@ -758,7 +758,8 @@ Datum Lingo::getTheEntity(int entity, Datum &id, int field) {
d.u.i = _vm->getVersion();
break;
case kTheSearchCurrentFolder:
getTheEntitySTUB(kTheSearchCurrentFolder);
//We always allow searching in current folder
Copy link
Member

@sev- sev- Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please issue a warning here, something like "BUILDBOT: SearchCurrentFolder is queried".

And as discussed add a similar warning to the setting of the property, so we can catch when it is used.

@@ -1042,6 +1044,9 @@ void Lingo::setTheEntity(int entity, Datum &id, int field, Datum &d) {
// Allow director version change: used for testing version differences via the lingo tests.
_vm->setVersion(d.asInt());
break;
case kTheSearchCurrentFolder:
warning("BUILDBOT: SearchCurrentFolder is queried!!!");
Copy link
Member

@sev- sev- Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not queried here, but 'set'. Also, please remove the exclamation marks as we are already adding one 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants