New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCUMM: Improvements to sound override #4028
base: master
Are you sure you want to change the base?
Conversation
Without this code, the Putt-Putt Goes to the Moon remastered soundtrack fails to play at all and only the old music plays. With this code, the remastered music now plays (although as we determined in Discord, the soundtracks are mislabeled so the wrong music plays, but that's a soundtrack issue, not a code issue). |
The feature will now only be active if the user enables game-specific enhancements, instead of being permanently enabled.
Fixed some issues and implemented partially the Ticket #13602. The feature is now behind the option "Enable game-specific enhancements". The option to toggle the feature on or off while the game is running is not implemented. |
Confirmed it still works with Putt-Putt Goes to the Moon and Putt-Putt Saves the Zoo. It is also properly affected by the
This is a bit confusing. The tooltip description says "Allow ScummVM to make small enhancements to the game, usually based on other versions of the same game." Which I don't think really describes the soundtrack enhancements. Is it possible to change the option to say something specific to sound and music? Also, would it make sense to move such a setting to the Audio tab? |
I've moved the feature to "Use external audio". It can be set in the Game Options and in the pause menu. I'm not sure if this is the correct way to implement it. Feedback is welcome.
If I understood the code correctly I can't add an engine-specific option in the Audio tab. I have to keep it in the Game tab. |
This is a follow-up of PR #2569.
Files can now be located in a separate directory "speech" or "sound". The search order is:
The speech files follow the same structure but use the offset from HE2 as ID because that is the only viable way to locate a specific audio clip.