Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Let Cast class manage registering the archive #4030

Merged
merged 1 commit into from Jun 23, 2022

Conversation

henke37
Copy link
Contributor

@henke37 henke37 commented Jun 21, 2022

This fixes a null pointer crash and potential issues when switching between movies.

Examples: Let's play dressup with Bert (exit), Learn the art of magic (instant)

@sev-
Copy link
Member

@sev- sev- commented Jun 21, 2022

Does it still crash with the latest master?

@henke37
Copy link
Contributor Author

@henke37 henke37 commented Jun 23, 2022

I checked, b8d4168 fixed the crash. I'd still like to move the registrering code to the Cast class in order to simplify the management and address potential issue of switching between movies.

@sev-
Copy link
Member

@sev- sev- commented Jun 23, 2022

OK, that makes sense.

Please rebase.

@henke37
Copy link
Contributor Author

@henke37 henke37 commented Jun 23, 2022

Will do.

This fixes a null pointer crash and potential issues when switching between movies.
@sev-
Copy link
Member

@sev- sev- commented Jun 23, 2022

Thanks

@sev- sev- merged commit 1b6e233 into scummvm:master Jun 23, 2022
8 checks passed
@henke37 henke37 deleted the sharedcastarchive branch Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants