Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: Improve King's Quest 4 detection entries #4137

Merged
merged 1 commit into from Aug 3, 2022

Conversation

OmerMor
Copy link
Contributor

@OmerMor OmerMor commented Jul 26, 2022

  1. Added a missing King's Quest 4 entry.
  2. Added missing version information to some King's Quest 4 entries.
  3. Sorted King's Quest 4 detection entries by version and platform.

@bluegr
Copy link
Member

@bluegr bluegr commented Jul 26, 2022

Thanks! However, please change the commit message according to our guidelines (add a "SCI: " in the front)

@OmerMor OmerMor changed the title Improve King's Quest 4 detection entries SCI: Improve King's Quest 4 detection entries Jul 30, 2022
@OmerMor
Copy link
Contributor Author

@OmerMor OmerMor commented Jul 30, 2022

Done.

@sluicebox
Copy link
Member

@sluicebox sluicebox commented Jul 30, 2022

Great! Sorting is a big help and we can never have enough version info. I've found KQ4 to be one of the harder games to map out the version history for. The four pieces of info (int ver, game ver, int date, game date) have so many sources (disk labels, QA file, about box in game script, executable string) and they're not always in agreement. Version strings like ".247" and ".274" are easy to typo and get confused about, and I saw pictures on ebay that suggest that happened on some floppy labels. I would love to sit down someday and start filling out these detection entries with all these details. Just as soon as we run out of script bugs!

We are indeed missing a detection entry for KQ4 DOS 1.003.006; it's quite a rare version, but this new entry is for a single (large) resource volume that someone generated with a third party repackaging tool, so I don't think that should be included. We could put a TODO noting that we still need DOS 1.003.006. (Not to be confused with 1.006.003!) I have confirmed with that repackaged copy that DOS 1.003.006 has identical scripts to Atari ST 1.003.006.

FWIW, here's my summary of KQ4 game versions:

1.000.106
1.000.111
1.003.006 (DOS and Atari ST)
1.006.003
1.006.004 (only script difference is version and date strings)
1.023 (Amiga, final version, mostly sound changes)

@sev-
Copy link
Member

@sev- sev- commented Aug 2, 2022

@bluegr ready for the merge?

@bluegr
Copy link
Member

@bluegr bluegr commented Aug 3, 2022

Thanks for the heads up @sev-
Looks good now! Thanks, merging

@bluegr bluegr merged commit 145d6bc into scummvm:master Aug 3, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants