Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: FREDDI4: workaround lipsync issues in final scene #4138

Merged
merged 1 commit into from Aug 2, 2022

Conversation

BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Jul 27, 2022

This workarounds https://bugs.scummvm.org/ticket/3533

In general, there seems to be some opcodes in the costume scripts that should be skipped by some unknown condition...
The animation frames in the same costume (809) seems to be 2 sequences:

  • freddi talks
  • luther talks

So the genral flow of this costume is

  • when freddi finishes moving her lips, it's luther turns
  • when luther finishes moving his lips, voice become disembodied

for now, this is somewhat hacky solution to loop when the sequence ends prematurely by the counting the amount of lines to be said.

NOTE: This bug does not occur in the original interperter, so there should be some other method, that should solve it from the root cause.

@Thunderforge
Copy link
Contributor

@Thunderforge Thunderforge commented Jul 28, 2022

Tested locally with all conversation options and it works great!

@sev-
Copy link
Member

@sev- sev- commented Aug 2, 2022

Thank you.

@sev- sev- merged commit 16955a1 into scummvm:master Aug 2, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants