Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Support unicode and BiDi in editable widget #4144

Merged
merged 1 commit into from Aug 2, 2022

Conversation

BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Jul 28, 2022

This allow writing unicode to editable text input, including BiDi support (write RTL and LTR languages together).
The neat trick here is appending single space to calculate the caret position which changes according to last character direction.

@BLooperZ BLooperZ force-pushed the editable_input_unicode branch from 82af497 to cb28e9a Compare Jul 28, 2022
@orgads orgads force-pushed the editable_input_unicode branch 2 times, most recently from 8ce3d77 to 88d5689 Compare Jul 29, 2022
@BLooperZ BLooperZ force-pushed the editable_input_unicode branch from 88d5689 to 0ae8f8f Compare Jul 29, 2022
@orgads
Copy link
Contributor

@orgads orgads commented Jul 29, 2022

LGTM. Thank you!

@sev-
Copy link
Member

@sev- sev- commented Aug 2, 2022

Awesome, thank you!

@sev- sev- merged commit b67b88e into scummvm:master Aug 2, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants