Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Add detection for many old games/demos and some new versions #4151

Closed
wants to merge 5 commits into from

Conversation

tag2015
Copy link
Contributor

@tag2015 tag2015 commented Aug 2, 2022

  • Detection for old demos (from mixnmojo.com)
  • Detection for old MAGS and OROW games (AGS forums/archive)
  • Detection for new versions reported in issue 13738

@sev-
Copy link
Member

sev- commented Aug 2, 2022

There is something weird with GitHub or perhaps the repo? I see more changes in the individual commits than in the end result.

Could you please check that the checksums are present in the diff?

@criezy
Copy link
Member

criezy commented Aug 2, 2022

If you see something in the end result you went further than me 😛

I checked the individual commits and they look fine. But I am unable to see the end result. By default it is not rendered because it is too big, and if I try to see it I get an error.
image

@criezy
Copy link
Member

criezy commented Aug 2, 2022

I pulled your branch locally and checked that it was all good. And since I had everything locally I also pushed the changes. So this was merged manually.

Thank you for the changes,

@criezy criezy closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants