Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMIGAOS: Fix target installation #4152

Merged
merged 1 commit into from Aug 5, 2022
Merged

AMIGAOS: Fix target installation #4152

merged 1 commit into from Aug 5, 2022

Conversation

raziel-
Copy link
Contributor

@raziel- raziel- commented Aug 3, 2022

  • Fix an edge-case error during target installation
  • Change hardcoded "cp" to it's envvar equivalent

Using
--disable-engine-all
together with plugins will lead to an empty plugins directory/list.
In turn, at least on my platform, both "cp" and "strip" will error out due to missing source files, breaking the rest of the installation.

This fix checks if there are plugins available before attempting to install them, otherwise plugins installation is simply skipped.

It works here locally with and without plugins compiled.

NB: A quick peek at the other targets show that

  • opendingux and
  • riscos
    might be affected aswell?
    But due to me knowing nothing about those platforms or how "cp" will react there on missing source files, I'll leave them be.
    Also, this is such an edge-case it's probably not worth the hassle?

But maybe someone still wants to alert the porters?

If this is the wrong approach, please shout.

Thank you

@sev-
Copy link
Member

@sev- sev- commented Aug 5, 2022

Thank you!

@sev- sev- merged commit 01cb613 into scummvm:master Aug 5, 2022
8 checks passed
@raziel- raziel- deleted the patch-3 branch Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants