AMIGAOS: Fix target installation #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Using
--disable-engine-all
together with plugins will lead to an empty plugins directory/list.
In turn, at least on my platform, both "cp" and "strip" will error out due to missing source files, breaking the rest of the installation.
This fix checks if there are plugins available before attempting to install them, otherwise plugins installation is simply skipped.
It works here locally with and without plugins compiled.
NB: A quick peek at the other targets show that
might be affected aswell?
But due to me knowing nothing about those platforms or how "cp" will react there on missing source files, I'll leave them be.
Also, this is such an edge-case it's probably not worth the hassle?
But maybe someone still wants to alert the porters?
If this is the wrong approach, please shout.
Thank you