PINK: Use the actual target when searching for saves #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
reviewed
Aug 4, 2022
| @@ -146,10 +146,9 @@ struct SaveStateDescriptorTimeComparator { | |||
| } | |||
| }; | |||
|
|
|||
| static SaveStateList listSaves(bool isPeril) { | |||
There was a problem hiding this comment.
Instead of removing static, you can pass the targetName as an argument in place of the boolean.
There was a problem hiding this comment.
Eh, the implicit this argument is just as expensive to pass, if not cheaper.
There was a problem hiding this comment.
You still need to access the _targetName member... So that's equivalent.
And by passing the target name by reference it's like passing a pointer.
This minimizes the changeset.
There was a problem hiding this comment.
Now I need two members from the class. It's now less params to pass.
sev-
reviewed
Aug 4, 2022
This ensures consistent behavior between listing and loading of saves
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This ensures consistent behavior between listing and loading of saves.
I was getting strange results with my localized version, seems like i have saves using both the
perilandperil-seprefixes. With this change both listing and loading uses the newperil-seprefix.