Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: OPENGLSDL: Fix corrupted graphics. #4155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlo-bramini
Copy link
Contributor

@carlo-bramini carlo-bramini commented Aug 3, 2022

Size of the alpha channel is not set to its default value and this caused totally corrupted graphics on my PC.
See:
https://bugs.scummvm.org/ticket/13712

@aquadran
Copy link
Member

@aquadran aquadran commented Aug 3, 2022

commit prefix is wrong

Copy link
Member

@aquadran aquadran left a comment

commit prefix is wrong

@carlo-bramini
Copy link
Contributor Author

@carlo-bramini carlo-bramini commented Aug 3, 2022

commit prefix is wrong

Excuse me, how should I change it?
Would "OPENGL: Fix corrupted graphics" be better?

@antoniou79
Copy link
Contributor

@antoniou79 antoniou79 commented Aug 3, 2022

commit prefix is wrong

Excuse me, how should I change it? Would "OPENGL: Fix corrupted graphics" be better?

It would be conforming to the format rules for the commit message, indeed.
You can have a look at the history of commits for the specifc file that is changed by this commit, to use the most appropriate prefix.
https://github.com/scummvm/scummvm/commits/cd00fa6bdb740a567e5cdd70dba4bf218ed7851b/backends/graphics/openglsdl/openglsdl-graphics.cpp

In the history there are commits with "OPENGL: ", "SDL: ", "BACKENDS: OPENGLSDL" (I think I prefer this one as more appropriate), "OPENGLSDL: ".

Size of the alpha channel is not set to its default value and this caused totally corrupted graphics on my PC.
See:
https://bugs.scummvm.org/ticket/13712
@carlo-bramini carlo-bramini changed the title [OPENGL] Fix corrupted graphics. BACKENDS: OPENGLSDL: Fix corrupted graphics. Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants