Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare custom help support #4162

Merged
merged 3 commits into from Aug 7, 2022
Merged

Declare custom help support #4162

merged 3 commits into from Aug 7, 2022

Conversation

henke37
Copy link
Contributor

@henke37 henke37 commented Aug 5, 2022

It's a distraction to have a button that doesn't do anything useful in all but one engine. So hide it when not supported.

@bluegr
Copy link
Member

@bluegr bluegr commented Aug 7, 2022

Clean and straightforward implementation, thanks!
The Help button should be visible if it's actually showing something, and as you said, it's only working in the SCUMM engine now.
Merging

@bluegr bluegr merged commit f668e4a into scummvm:master Aug 7, 2022
8 checks passed
@henke37 henke37 deleted the noHelp branch Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants