Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix AGI/SCI Fanmade title in gridview #4175

Closed

Conversation

treloret
Copy link
Contributor

@treloret treloret commented Aug 10, 2022

GUI: Fix title in gridview for AGI/SCI fanmade games

In gridview the title for AGI/SCI fanmade was identical for all fanmade games, checked the previous version before this behavior was introduced to come up with a fix for these edge cases. Since it specifically checks for those type of games, others should be unaffected. Ticket 13719

@bluegr
Copy link
Member

bluegr commented Aug 13, 2022

That is not an optimal approach. We are performing engine-specific checks in common code. It would be best if appropriate changes were done to the engines themselves

@treloret
Copy link
Contributor Author

treloret commented Aug 13, 2022

That's as far as my C++ knowledge will carry me. I just re-instituted the old behavior before the commit that broke the naming. Better to rescind this PR?

@treloret
Copy link
Contributor Author

treloret commented Aug 13, 2022

Basically the previous code should be reinstated and cleaned, and the underlying object should have a property that is just the game description without the version specific stuff between parentheses. But I have no clue how to do that, not using an IDE here, just a text editor and a compiler to tell me if I made a mistake.

@bluegr
Copy link
Member

bluegr commented Aug 26, 2022

So, which commit broke the behavior in this case?

@treloret
Copy link
Contributor Author

treloret commented Aug 27, 2022

beafbca according to a previous thread on discord

@sev-
Copy link
Member

sev- commented Sep 18, 2022

Well, this approach is definitely a no-go. One of the ways to address it is by showing description instead of the standard title.

@sev- sev- closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants