Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLK/ADRIFT: Add missing entries for letter A, add prefix checked games #4179

Closed

Conversation

treloret
Copy link
Contributor

@treloret treloret commented Aug 11, 2022

GLK/ADRIFT: Add missing entries for letter A, add prefix checked games

Add a prefix to identify them from other glk games, adX where X is the major version (3, 4, and the unsupported 5), only partially done for now, while I keep checking letters

Add game detection:

  • A Day In The Life 3- Akari's Story
  • The Alchemist
  • Alexis-Dalskee
  • Another Friday Party
  • Archie's Birthday - Chapter 1: Reggie's Gift
  • Asylum
  • The Average Life
  • Adventures of Bob Bobsly
  • Adventures of Thumper - Wonder Wombat
  • ADRIFTMAS Party
  • Adventure
  • Aegis
  • Albert is Lost!- An Adventure in Real Life
  • Alias- Undercover Agent
  • Alice's Restaurant Anti-Massacree Adventure
  • All Hallows Eve
  • The Amazing Uncle Griswold
  • The Amazing TV Caper
  • Amnesia Kid
  • Amy And The Raging Hormones
  • The Angel, the Devil and the Human
  • Apokalupsis
  • Asteroid Aftermath
  • Attack of Doc Lobster's Mutant Menagerie of Horror
  • El Ancesor
  • Attack of the Mutaydid Meat Monsters
  • The Adventures of Postman Matt (and his black and white cat)
  • The Adventures of Space Boy! Volume II

@bluegr
Copy link
Member

bluegr commented Aug 11, 2022

Why are we changing the game IDs here? We don't need to reflect the ADRIFT version information to the user in this manner, do we?
Can't we just use a different DT_ENTRY0 macro, or add appropriate comments to each entry?

@treloret
Copy link
Contributor Author

treloret commented Aug 11, 2022

To prevent overlap and quickly identify the subengine, Adventure being the prime example, don't think any self respecting IF engine doesn't have a port for Adventure, be it the original or the 350+ versions. From the games I just added, numerous had their own versions in different engines. And 3 character identifier just seems right having just checked most of the AGI and SCI fanmade games last year and this year. And I'm going to try to tackle glk one sub-engine at a time.

@treloret
Copy link
Contributor Author

treloret commented Aug 11, 2022

I can provide a link with these additions packed up nicely, since all of them are freeware. Easier than doing what I did.

@treloret
Copy link
Contributor Author

treloret commented Aug 13, 2022

As a side note, to further defend my madness, I've already found a few miss-attributed unsupported ADRIFT 5 games, that were actually 3.90

@sev-
Copy link
Member

sev- commented Sep 18, 2022

Please, revert the engine prefix. We do not do it for any of the engines normally. You may put the version information in the comments or in the extra field in the detection entry.

@treloret treloret closed this Sep 18, 2022
@sev-
Copy link
Member

sev- commented Sep 18, 2022

Why did you close the PR?

@treloret
Copy link
Contributor Author

treloret commented Sep 19, 2022

Adrift has postfixes with ... adrift, AGT has prefixes with agt, TADS has postfixes with version number, glulx has plenty of postfixes with glulx. And I don't feel like going through A-D again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants