Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Adjust ADGameFlags to fit the specified range #4230

Merged
merged 1 commit into from Sep 18, 2022

Conversation

ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Aug 22, 2022

The ADGameDescription struct has the following comment about the flags:

/**
 * A bitmask of extra flags.
 *
 * The top 16 bits are reserved for generic flags defined in @ref ADGameFlags.
 * This leaves 16 bits to be used by the client code.
 */

However, the value of ADGF_TAILMD5 is in the lower 16-bits, rather than the top 16-bits. This PR fixes that discrepancy.

@sev-
Copy link
Member

sev- commented Aug 22, 2022

I would suggest switching it to uint64

@sev-
Copy link
Member

sev- commented Aug 22, 2022

Ah, I see that you're trying to reduce the size of the detection plugin.

One of the things which I have been thinking about for a while now is moving our detection data into an external XML file. At least for those engines that use AdvancedDetector.

@sluicebox
Copy link
Member

sluicebox commented Aug 25, 2022

One of the things which I have been thinking about for a while now is moving our detection data into an external XML file. At least for those engines that use AdvancedDetector.

That would be very interesting; we have some SCI32 Mac games that can't fit in the 13-file limit of the detection struct's array. They're made up of many small files that span many discs with generic names so it's important to include them all. I don't know if any other AD engines have hit this limit.

@sev-
Copy link
Member

sev- commented Aug 29, 2022

@sluicebox you need to include a minimal set of distinct files, not all of them. Are you sure you have to rely on so many files in order to detect a game?

@sluicebox
Copy link
Member

sluicebox commented Aug 29, 2022

@sev- The multi-disc SCI32 Mac games are an extreme situation. Dozens of tiny files with identical names but different content on 6 CDs. We don't support these particular multi-disc Mac versions yet, but the 13-file limit is just one of the challenges. It's not the blocker. But I'll be very interested if a more flexible scheme emerges.

@sev-
Copy link
Member

sev- commented Sep 18, 2022

@sluicebox I do not understand, though, why do you need files from all 13 disks for uniquely identifying a game variant. The detection entries should be kept to a minimus size, so the detection code works fast.

@sev-
Copy link
Member

sev- commented Sep 18, 2022

Anyway, merging this as it is a good change.

@sev- sev- merged commit fbd379c into scummvm:master Sep 18, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants