Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVIE: Fix bug - https://bugs.scummvm.org/ticket/13809 #4249

Merged
merged 1 commit into from Sep 6, 2022

Conversation

lolovo
Copy link
Contributor

@lolovo lolovo commented Aug 31, 2022

we should take minimum to be sure that we won't exceed maximum size and didn't fail on assertion

min value should be taken to pass assertion inside of seek to avoid crash using localized files
@antoniou79 antoniou79 requested a review from Die4Ever Sep 1, 2022
@Die4Ever Die4Ever self-assigned this Sep 2, 2022
@Die4Ever
Copy link
Member

Die4Ever commented Sep 6, 2022

good stuff, thank you

I'm gonna do a squash merge so I can improve the commit message

@Die4Ever Die4Ever merged commit 78a19f1 into scummvm:master Sep 6, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants