Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVIE: stop fast video playback capability #4250

Merged
merged 3 commits into from Sep 21, 2022

Conversation

lolovo
Copy link
Contributor

@lolovo lolovo commented Aug 31, 2022

cancelation of fast playback video by right mouse click and proceed watching video with normal speed and sound. It is needed to prevent skipping ghost scenes after speed up slow movement in game.

stop fast video playback by clicking right mouse button and proceed watching video with normal speed and sound.
@antoniou79 antoniou79 requested a review from Die4Ever Sep 1, 2022
@Die4Ever Die4Ever self-assigned this Sep 2, 2022
@Die4Ever
Copy link
Member

Die4Ever commented Sep 6, 2022

I just realized this would ruin speedrunning, I liked the idea though, maybe this can be done in a different way or with a dedicated keyboard key? maybe escape?

but functionally the code looks correct and I tested it and it does work well

@lolovo
Copy link
Contributor Author

lolovo commented Sep 6, 2022

The only problem of fast playback is skiping scenes with ghosts when you speed up very slow animated movements (walking) in the 7th guest. It concerns almost all scenes in the game due to they start right after movement that is very slow and would be forwarded by most players. So dedicated keyboard key won't help and not convenient on android at least.
The alternatine way (maybe the best solution in this case) is setting _videoSkipAddress for the 7th guest like it was done in the 11th hour that would help just skip very slow movement animation during walking and watch scenes after it.
P.S. But I'm not sure if ghost scenes are separated from movement? If not, then _videoSkipAddress should equal to position when movement ends but not clip ends

@Die4Ever
Copy link
Member

Die4Ever commented Sep 21, 2022

I'm adding a new option for speedrun mode which is current skipping behavior, and the default is the behavior you have here

@Die4Ever
Copy link
Member

Die4Ever commented Sep 21, 2022

also now when speedrun_mode is disabled, the fast forwarding will stop when a different video starts

Copy link
Member

@Die4Ever Die4Ever left a comment

this looks good to me and I tested it too

@lolovo since you started this I'd like to hear your thoughts before merging it

@lolovo
Copy link
Contributor Author

lolovo commented Sep 21, 2022

@Die4Ever I think it will be the best solution - option for speedrun mode! I've tested it and it works good to me also!) Thanks! Btw it is also need to add translation of this option in *.po files.

@Die4Ever
Copy link
Member

Die4Ever commented Sep 21, 2022

@Die4Ever I think it will be the best solution - option for speedrun mode! I've tested it and it works good to me also!) Thanks! Btw it is also need to add translation of this option in *.po files.

translations happen after merging, I guess I'll merge this now, probably best to do a squash merge for this

@Die4Ever Die4Ever merged commit 25f859a into scummvm:master Sep 21, 2022
8 checks passed
einstein95 pushed a commit to einstein95/scummvm that referenced this pull request Sep 30, 2022
* GROOVIE: stop fast video playback capability
stop fast video playback by clicking right mouse button and proceed watching video with normal speed and sound.

* Update script.cpp

* GROOVIE: speedrun mode option

Co-authored-by: Die4Ever <die4ever2005@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants