Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI32: Make RTL BiDi conversion direction hard coded #4256

Merged
merged 1 commit into from Sep 5, 2022

Conversation

ZvikaZ
Copy link
Contributor

@ZvikaZ ZvikaZ commented Sep 5, 2022

The default behaviour for Common::convertBiDiString is to use
BIDI_PAR_ON for direction, which means that it tries to guess to
paragraph language, and choose the direction according to it.

However, in SQ6 many (all?) texts begin with control characters,
which make that function to think that these are English texts,
and therefore it chooses LTR direction, and punctuations are wrongly
placed.

Since the call to the function is under if clause for RTL,
it's safe to hard code that direction.

The default behaviour for `Common::convertBiDiString` is to use
BIDI_PAR_ON for direction, which means that it tries to guess to
paragraph language, and choose the direction according to it.

However, in SQ6 many (all?) texts begin with control characters,
which make that function to think that these are English texts,
and therefore it chooses LTR direction, and punctuations are wrongly
placed.

Since the call to the function is under `if` clause for RTL,
it's safe to hard code that direction.
@bluegr
Copy link
Member

bluegr commented Sep 5, 2022

Thanks!

@bluegr bluegr merged commit 34873d1 into scummvm:master Sep 5, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants