Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Allow rendering v2 games in forced Amiga mode again #4273

Conversation

dwatteau
Copy link
Contributor

@dwatteau dwatteau commented Sep 18, 2022

Commit 2fe65d9 limited render modes to suitable targets, but many users are used to render the DOS/V2 versions of Maniac Mansion and Zak in Amiga mode, to avoid the so-called "sunburn effect". Playing the game with this setting doesn't cause any issue, as far as I know.

scummvm-maniac-v2-00000
scummvm-maniac-v2-00001

This trick was known for years I believe, it was mentioned somewhere on our forums and PC Gaming Wiki even mentions it:

Tested with my English and French V2/DOS versions of Maniac Mansion and Zak. I don't know if using the Amiga render mode on the Atari ST version works as well, though…

@athrxx: Do you see a problem with this change?

Commit 2fe65d9 limited render modes to
suitable targets, but many users are used to render the DOS/V2 versions
of Maniac Mansion and Zak in Amiga mode, to avoid the so-called "sunburn
effect".  Playing the game with this setting doesn't cause any issue, as
far as I know.
@dwatteau dwatteau requested a review from athrxx Sep 18, 2022
@athrxx
Copy link
Member

athrxx commented Sep 18, 2022

No, I guess this is okay. You have to activate this expressly and willingly, so noone can blame us for having wrong colors :-)

And you also added a comment, so we'll remember the reason for it 👍

In theory, it could cause confusion if someone selects Amiga rendering in the global options, but who would do such a thing...
This is more a shortcoming of our launcher. We shouldn't really offer platform specific rendering types as global options.

@athrxx
Copy link
Member

athrxx commented Sep 18, 2022

This is such a minor modification. I think we can just merge this...

@athrxx athrxx merged commit 4586d2f into scummvm:master Sep 18, 2022
8 checks passed
@dwatteau dwatteau deleted the fix/scumm-allow-amiga-render-mode-for-dos-v2-again branch Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants