Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Add basic text node support to XMLParser #4274

Merged
merged 1 commit into from Sep 22, 2022

Conversation

mduggan
Copy link
Contributor

@mduggan mduggan commented Sep 18, 2022

I'm working on an engine that needs basic text node support in the XML parser.

This is a simple implementation which I think works for my needs, but I'm open to other ideas - eg, should it provide the active element name, or some other structure with more information?

common/xmlparser.cpp Outdated Show resolved Hide resolved
common/xmlparser.h Outdated Show resolved Hide resolved
@bluegr
Copy link
Member

bluegr commented Sep 22, 2022

Straightforward change, without causing any regression. Nice work, merging

@bluegr bluegr merged commit 64681f5 into scummvm:master Sep 22, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants