Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: GUI: remove forced alignment #4275

Merged
merged 1 commit into from Sep 18, 2022
Merged

Conversation

BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Sep 18, 2022

Following the wonderful work of @AndywinXp and @athrxx for implementing original GUI [1] and perfecting string rendering

The removed block of code is no longer needed, and seems to cause problems on original GUI display on Hebrew (which the block is scoped to).

Thanks

[1] #4206

@AndywinXp
Copy link
Contributor

AndywinXp commented Sep 18, 2022

Thanks! Being that the changes only affect the Hebrew versions this looks good to me! I'm curious about how it renders with this change, do you have a pic? 😄

@BLooperZ
Copy link
Contributor Author

BLooperZ commented Sep 18, 2022

Sure!

COMI:
before:
comigui-r
after:
comigui-a

FT (now need to translate the text 😄 ):
before:
ft-r
after:
ft-a

the comparison in The Dig looks the same as FT

Sam & Max is unaffected by this change, it's already look good

@AndywinXp
Copy link
Contributor

AndywinXp commented Sep 18, 2022

Thanks! Merging!

@AndywinXp AndywinXp merged commit 99e213b into scummvm:master Sep 18, 2022
5 of 8 checks passed
@BLooperZ
Copy link
Contributor Author

BLooperZ commented Sep 18, 2022

CC @orgads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants