Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Let it build again without ENABLE_SCUMM_7_8 #4281

Merged
merged 1 commit into from Sep 20, 2022

Conversation

dwatteau
Copy link
Contributor

@dwatteau dwatteau commented Sep 20, 2022

Hi,

This should let the SCUMM engine build again without ENABLE_SCUMM_7_8 (e.g. ./configure --disable-all-engines --enable-engine=scumm), since the latest GUI changes (my test environment is macOS 12.6 with clang++ 14.0).

Submitting it as a PR because I don't know the whole context and I'm not sure my change in engines/scumm/input.cpp is that elegant.

@dwatteau dwatteau requested a review from AndywinXp Sep 20, 2022
Copy link
Contributor

@AndywinXp AndywinXp left a comment

I don't mind the way the changes are done, frankly. If nobody else has any issues with this, I'll merge the PR tonight. Thanks!

@sev-
Copy link
Member

sev- commented Sep 20, 2022

Thanks!

@sev- sev- merged commit 80e134a into scummvm:master Sep 20, 2022
8 checks passed
@dwatteau dwatteau deleted the fix/scumm-builds-without-v7-v8 branch Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants