Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VKEYBD: Repair the apostrophe key in the virtual keyboard #4284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dwatteau
Copy link
Contributor

@dwatteau dwatteau commented Sep 23, 2022

The target and name attributes for the apostrophe key (straight ' in ASCII, not the real typographic apostrophe) didn't use the same character in the XML tables, so they never matched and this particular key had no effect in the virtual keyboard.

To test this PR:

  1. Build ScummVM with --enable-vkeybd
  2. Make sure that you have a valid vkeybdpath value pointing to the new files (such as /path/to/git/scummvm/backends/vkeybd/packs) in your configuration file
  3. Open the virtual keyboard within ScummVM (default shortcut on desktop is Ctrl-F7)
  4. Click on the apostrophe key on the virtual keyboard (immediately on the left of the Enter key)
  5. Make sure that it outputs a proper ' character (it used to do nothing before this)

(The zip files were rebuilt with vkeybdpack.py makeall; the biggest one went 6KB larger, so I added compresslevel=9 to the Python script in order to go back to the previous sizes)

dwatteau added 2 commits Sep 23, 2022
So that the .zip files don't get too big.
The `target` and `name` attributes for this key didn't use the same
character, so they never matched and the key had no effect.
@dwatteau dwatteau force-pushed the fix/vkeybd-apostrophe-key branch from 37cf32d to a3190ee Compare Sep 23, 2022
This was encoded in Windows-1252 and it triggered a
-Winvalid-source-encoding warning. Just use ASCII, as for the other
descriptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant