Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBRETRO: add libretro platform #4683

Merged
merged 1 commit into from Mar 4, 2023
Merged

Conversation

spleen1981
Copy link
Contributor

No description provided.

@BallM4788
Copy link
Contributor

BallM4788 commented Feb 4, 2023

As someone who's unfamiliar with how libretro works (and with only passing knowledge of RetroArch), what's the difference between this PR and your work over at libretro/scummvm? Does that repository not already provide what's needed to make a ScummVM core for RetroArch?

I'm not a member of the ScummVM team, but a PR description may help in case team members have that question as well.

@spleen1981
Copy link
Contributor Author

There is no difference with current libretro core. It's same sources rearranged to fit ScummVM tree (while current core sources are structured as a wrapper with a scummvm git submodule). Purpose is to eventually drop current core repo and directly use ScummVM official repo instead.

This has been discussed with ScummVM Team in advance.

@i30817
Copy link
Contributor

i30817 commented Feb 5, 2023

Hopefully the code here keeps being worked on until at least the opengl renderer works, not just keep building. That was always the worst loss on libretro-scummvm, especially for 3d games. Although i guess that's 'difficult' if you want it to happen on the console implementations of opengl.

.gitlab-ci.yml Show resolved Hide resolved
Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. I had only a few notes/suggestions

backends/platform/libretro/Makefile Outdated Show resolved Hide resolved
backends/platform/libretro/dependencies.mk Show resolved Hide resolved
backends/platform/libretro/dist/README.md Outdated Show resolved Hide resolved
backends/platform/libretro/include/config.h Show resolved Hide resolved
backends/platform/libretro/include/libretro-threads.h Outdated Show resolved Hide resolved
backends/platform/libretro/src/libretro-fs.cpp Outdated Show resolved Hide resolved
backends/platform/libretro/src/libretro-os.cpp Outdated Show resolved Hide resolved
backends/platform/libretro/src/libretro-os.cpp Outdated Show resolved Hide resolved
backends/platform/libretro/src/libretro-os.cpp Outdated Show resolved Hide resolved
sev-
sev- approved these changes Feb 7, 2023
Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no further notes so far.

@sev- sev- merged commit 36446fa into scummvm:master Mar 4, 2023
1 check passed
@spleen1981 spleen1981 deleted the add_libretro branch March 4, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants