GLK: Embed the Infocom fonts in the executable #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,42 @@ | |||
| #define infocom6x8_width 192 | |||
There was a problem hiding this comment.
Could you append a .h extension to xbm files?
It's better as they are not xbm now.
There was a problem hiding this comment.
This is a valid XBM file - they're designed to allow including them into C/C++ source code, which is why I chose it instead of BMP.
There was a problem hiding this comment.
Woah! I didn't know! Thanks for the explanation
|
Yes, it makes sense. I'll regenerate fonts.dat when there are other significant changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The Infocom fonts were the only files in
fonts.datthat don't require FreeType. The overall increase in executable size shouldn't be noticeable.